| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: partitioning code reorganization |
| Date: | 2018-04-14 11:51:40 |
| Message-ID: | 20180414115140.3oxnddryke6rmtvq@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here's a final version.
The one thing I don't like about this is having put
PartitionRangeDatumKind in partdefs.h, which forces us to #include that
file in parsenodes.h. I had to do this in order to avoid #including
parsenodes.h in partbounds.h. Now maybe that is not so bad, since that
file isn't *that* widely used anyway; it wouldn't cause any unnecessary
bleeding of parsenodes.h into any other headers. So maybe I'll put the
enum back in parsenodes. Any opinions on that?
I intend to push this this evening.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Reorganize-partitioning-code-structure.patch | text/plain | 219.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2018-04-14 12:58:58 | Re: Proposal: Adding json logging |
| Previous Message | Юрий Соколов | 2018-04-14 07:09:19 | Re: Postgres stucks in deadlock detection |