From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Warnings and uninitialized variables in TAP tests |
Date: | 2018-04-09 01:15:17 |
Message-ID: | 20180409011517.GB11599@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi all,
While looking at the output of the TAP tests, I have seen warnings like
the following:
Use of uninitialized value $target_lsn in concatenation (.) or string at
/home/foo/git/postgres/src/bin/pg_rewind/../../../src/test/perl/PostgresNode.pm
line 1540.
[...]
./src/bin/pg_basebackup/tmp_check/log/regress_log_010_pg_basebackup:Use
of uninitialized value $str in print at
/home/foo/git/postgres/src/bin/pg_basebackup/../../../src/test/perl/TestLib.pm
line 244.
The first one shows somethng like 30 times, and the second only once.
Attached is a patch to clean up all that. In order to find all that, I
simply ran the following and they pop up:
find . -name "regress_log*" | xargs grep -i "uninitialized"
What I have found is harmless, still they pollute the logs.
Thanks,
--
Michael
Attachment | Content-Type | Size |
---|---|---|
tap-init-fix.patch | text/x-diff | 1.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2018-04-09 01:31:56 | Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS |
Previous Message | David Rowley | 2018-04-09 01:03:56 | Re: pgsql: Support partition pruning at execution time |