Re: pgsql: Fix timing issue in new subscription truncate test

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: pgsql: Fix timing issue in new subscription truncate test
Date: 2018-04-07 17:53:23
Message-ID: 20180407175323.5ajmrsvvillht2ky@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2018-04-07 13:31:53 -0400, Tom Lane wrote:
> Oh ... digging into that, it's because that test depends on hstore,
> which I hadn't installed. How much is that dependency really
> buying us?

There's some separate logic for non-core datatypes, so it seems good to
test that. Hstore seems like a reasonable choice for it.

> If there's a good reason to have it, we should
> (a) document the requirement in src/test/subscription/README,
> and (b) try to make the failure less obscure. I do not really find
> this to be an acceptable spelling of "you didn't install hstore":

No argument there.

Greetings,

Andres Freund

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-04-07 17:58:40 Re: pgsql: New files for MERGE
Previous Message Andres Freund 2018-04-07 17:51:52 Re: pgsql: New files for MERGE