| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | amul sul <sulamul(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key |
| Date: | 2018-04-07 15:15:01 |
| Message-ID: | 20180407151501.n3m652jzjwjljlel@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
amul sul wrote:
> On Sat, Apr 7, 2018 at 9:08 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> >> +test: partition-key-update-1
> >> +test: partition-key-update-2
> >> +test: partition-key-update-3
> >
> > Can you give these more descriptive names please (or further combine them)?
>
> As I explained above further combining might not the good option and about
> the descriptive names I have following suggestions but I am afraid of
> the length of
> test case name:
>
> +test: concurrent-partition-key-update.out
>
> This test does the serialization failure check.
>
> +test: concurrent-partition-key-update-and-insert-conflict-do-nothing-1
> +test: concurrent-partition-key-update-and-insert-conflict-do-nothing-2
Yikes. I'd rather have the original name, and each test's purpose
stated in a comment in the spec file itself.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2018-04-07 15:16:22 | Re: Boolean partitions syntax |
| Previous Message | Teodor Sigaev | 2018-04-07 15:09:12 | Re: json(b)_to_tsvector with numeric values |