Re: pgsql: New files for MERGE

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: New files for MERGE
Date: 2018-04-06 16:22:09
Message-ID: 20180406162209.GL29402@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Apr 6, 2018 at 09:21:54AM +0100, Simon Riggs wrote:
> On 5 April 2018 at 21:02, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Simon, you have three committers in this thread suggesting this patch be
> > reverted. Are you just going to barrel ahead with the fixes without
> > addressing their emails?
>
> PeterG confirms that the patch works and has the agreed concurrency
> semantics. Separating out the code allows us to see clearly that we
> have almost complete test coverage of the code and its features.

My point was that people didn't ask you to work harder on fixing the
patch, but in reverting it. You can work harder on fixing things in the
hope they change their minds, but again, that isn't addressing their
request.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2018-04-06 16:39:01 pgsql: Add memory context identifier to portal context
Previous Message Robert Haas 2018-04-06 15:55:56 pgsql: Enforce child constraints during COPY TO a partitioned table.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-04-06 16:22:57 Mop-up for the bootstrap data conversion patch
Previous Message Andres Freund 2018-04-06 16:20:23 Re: [HACKERS] logical decoding of two-phase transactions