From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: New files for MERGE |
Date: | 2018-04-05 20:02:20 |
Message-ID: | 20180405200220.GG29402@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Thu, Apr 5, 2018 at 11:15:20AM +0100, Simon Riggs wrote:
> On 4 April 2018 at 21:28, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> > On 4 April 2018 at 21:14, Andres Freund <andres(at)anarazel(dot)de> wrote:
> >
> >>> The normal way is to make review comments that allow change. Your
> >>> request for change of the parser data structures is fine and can be
> >>> done, possibly by Saturday
> >>
> >> I did request changes, and you've so far ignored those requests.
> >
> > Pavan tells me he has replied to you and is working on specific changes.
>
> Specific changes requested have now been implemented by Pavan and
> committed by me.
>
> My understanding is that he is working on a patch for Tom's requested
> parser changes, will post on other thread.
Simon, you have three committers in this thread suggesting this patch be
reverted. Are you just going to barrel ahead with the fixes without
addressing their emails?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2018-04-05 20:05:42 | pgsql: Allow on-line enabling and disabling of data checksums |
Previous Message | Bruce Momjian | 2018-04-05 19:55:53 | pgsql: doc: remove mention of the DMOZ catalog in ltree docs |
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2018-04-05 20:06:36 | Re: Online enabling of checksums |
Previous Message | Heikki Linnakangas | 2018-04-05 20:02:09 | Re: Vacuum: allow usage of more than 1GB of work mem |