| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Incorrect use of "an" and "a" in code comments and docs |
| Date: | 2018-03-29 19:28:32 |
| Message-ID: | 20180329192832.GG16165@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 5, 2018 at 01:58:54PM +0900, Michael Paquier wrote:
> Hi all,
>
> While looking at something else, I have one one occurence of $subject.
> Looking more deeply at the code I have found 10 more of them, like:
> - sinval is a signal invalidation, so it seems to me that "a" is
> correct, not "an".
> - I bumped into "an" being used instead of "and" in the GIN code.
> - config/c-library.m4 also includes one. If that code is from somewhere
> else, fixing this typo would not be appropriate perhaps?
>
> Attached is a proposal of patch to fix all those things.
Attached patch applied. It includes a suggested fix by Abhijit
Menon-Sen.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| Attachment | Content-Type | Size |
|---|---|---|
| a.diff | text/x-diff | 7.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2018-03-29 19:29:24 | Re: Incorrect use of "an" and "a" in code comments and docs |
| Previous Message | Andres Freund | 2018-03-29 19:27:57 | Re: pgsql: Add documentation for the JIT feature. |