Re: [HACKERS] [PATCH] Lockable views

>> I found the previous patch was broken and this can't handle
>> views that has subqueries as bellow;
>>
>> 　CREATE VIEW lock_view6 AS SELECT * from (select * from lock_tbl1) sub;
>>
>> I fixed this and attached the updated version including additional tests.
>
> This patch gives a warning while compiling:
>
> lockcmds.c:186:1: warning: no semicolon at end of struct or union
> } LockViewRecurse_context;
> ^

Also I get a regression test failure:

*** /usr/local/src/pgsql/current/postgresql/src/test/regress/expected/lock.out 2018-03-28 15:24:13.805314577 +0900
--- /usr/local/src/pgsql/current/postgresql/src/test/regress/results/lock.out 2018-03-28 15:42:07.975592594 +0900
***************
*** 118,124 ****
------------
lock_tbl1
lock_view6
! (2 rows)

ROLLBACK;
-- Verify that we can lock a table with inheritance children.
--- 118,125 ----
------------
lock_tbl1
lock_view6
! mvtest_tm
! (3 rows)

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp