| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Петър Славов <pet(dot)slavov(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: BUG #15114: logical decoding Segmentation fault |
| Date: | 2018-03-26 16:19:26 |
| Message-ID: | 20180326161926.4jlm6c3vhy5wtos2@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi,
On 2018-03-26 13:08:01 -0300, Alvaro Herrera wrote:
> I agree -- I think logicalrep_write_attrs() should not use
> RelationGetIndexAttrBitmap at all but instead use some lower-level way
> to obtain columns of the replica identity.
Indeed.
> I don't know whether there are historical-snapshot-related
> considerations to care about, in this code, though.
There shouldn't be much of an issue if all that's accessed is system
tables/cols.
> This is neither my area nor my code, but if Petr and Peter decline
> producing a patch for this quickly, I can look at it in a few days.
Cool!
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chris Hanks | 2018-03-26 18:43:09 | Re: [BUGS] Connections hang indefinitely while taking a LWLockTranche buffer_content lock. |
| Previous Message | Alvaro Herrera | 2018-03-26 16:08:01 | Re: BUG #15114: logical decoding Segmentation fault |