Re: bugfifx: a minor mistake in brin_inclusion.c comment

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bugfifx: a minor mistake in brin_inclusion.c comment
Date: 2018-03-26 15:11:26
Message-ID: 20180326151126.6bouh22l4n3ynwcy@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tomas Vondra wrote:
> Hi,
>
> while looking at brin_inclusion.c, I've noticed that the comment about
> INCLUSION_UNMERGEABLE and INCLUSION_CONTAINS_EMPTY uses incorrect values
> (1 instead of 2). Attached is a simple fix.

Uh, yeah, this is wrong.

> But perhaps it would be better to use the constants in the comment.

I fixed it like this, which seems neater.

Thanks!

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-03-26 15:13:42 Re: Direct converting numeric types to bool
Previous Message Robert Haas 2018-03-26 15:09:42 Re: [HACKERS] MERGE SQL Statement for PG11