| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, tgl(at)sss(dot)pgh(dot)pa(dot)us, pavel(dot)stehule(at)gmail(dot)com, michael(dot)paquier(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs |
| Date: | 2018-03-16 01:21:39 |
| Message-ID: | 20180316012139.GD2666@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 15, 2018 at 01:33:51PM +0300, Arthur Zakirov wrote:
> I think your approach has a vulnerability too. I believe that a
> non GUC_LIST_INPUT extension GUC which was used to create a function may
> become GUC_LIST_INPUT variable. If I'm not mistaken nothing stops from
> that. In this case values in proconfigislist won't be valide anymore.
I don't understand what you mean here. Are you referring to a custom
GUC which was initially declared as not being a list, but became a list
after a plugin upgrade with the same name? Isn't the author to blame in
this case?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-03-16 01:23:54 | Re: [HACKERS] Lazy hash table for XidInMVCCSnapshot (helps Zipfian a bit) |
| Previous Message | Michael Paquier | 2018-03-16 01:18:59 | Re: Fixes for missing schema qualifications |