Re: pgsql: Remove pg_class.relhaspkey

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Remove pg_class.relhaspkey
Date: 2018-03-15 13:01:04
Message-ID: 20180315130104.sb7kjshhc4v6a2i5@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan wrote:

> As I mentioned upthread, it's not supposed to be, but was being due to
> a typo that I have fixed. You should see this error cleared on the
> dashboard in a few minutes.
>
> However, in general the module tries to do a maximal test. That
> includes almost all the contrib databases. That approach has helped
> reveal problems several times in the past.

Well, maybe we should dictate policy that it must be possible to
pg_upgrade this database too; then we'll just have to work so that it
always works. I have fixed the current problem and I'm open to the idea
of keeping it working.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2018-03-15 13:03:25 pgsql: restrict -> pg_restrict
Previous Message Alvaro Herrera 2018-03-15 12:58:05 pgsql: test_ddl_deparse: Don't use pg_class as source for a matview