From: | Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: committing inside cursor loop |
Date: | 2018-03-06 12:48:37 |
Message-ID: | 20180306154837.7a832ec0@wp.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, 20 Feb 2018 09:11:50 -0500
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> Here is a patch that allows COMMIT inside cursor loops in PL/pgSQL.
> As alluded to in earlier threads, this is done by converting such
> cursors to holdable automatically. A special flag "auto-held" marks
> such cursors, so we know to clean them up on exceptions.
>
> This is currently only for PL/pgSQL, but the same technique could be
> applied easily to other PLs.
>
Hi,
The patch still applies, tests passed. The code looks nice,
documentation and tests are there.
Although as was discussed before it seems inconsistent without ROLLBACK
support. There was a little discussion about it, but no replies. Maybe
the status of the patch should be changed to 'Waiting on author' until
the end of discussion.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Claudio Freire | 2018-03-06 12:52:16 | Re: Faster inserts with mostly-monotonically increasing values |
Previous Message | Etsuro Fujita | 2018-03-06 12:26:47 | Re: inserts into partitioned table may cause crash |