| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Change RangeVarGetRelidExtended() to take flags argument? |
| Date: | 2018-03-06 01:21:11 |
| Message-ID: | 20180306012111.6wgbpmsjyylz4365@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-03-06 10:17:49 +0900, Michael Paquier wrote:
> On Mon, Mar 05, 2018 at 05:06:59PM -0800, Andres Freund wrote:
> > Yea, that's a concern. OTOH, it doesn't seem nice to grow duplicates of
> > similar code. It'd not be too hard to move RangeVarGetRelidExtended()
> > code into RangeVarGetRelidInternal() and add
> > RangeVarGetRelidTryLock(). Not sure if that's any better. Or just add
> > RangeVarGetRelidExtended2() :)
>
> FWIW, it would have been nice to switch RangeVarGetRelidExtended
What exactly do you mean with the paste tense here?
> so as it handles a set of uint8 flags as one of its arguments.
Right, that's what I was proposing. Although I'd just go for uint32,
there's no benefit in uint8 here.
> Avoiding a new flavor of RangevarGet would be also nice, now
> RangeVarGetRelidExtended() is likely popular enough in extensions that
> much things would break.
I can't follow?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-03-06 01:32:00 | Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs |
| Previous Message | Michael Paquier | 2018-03-06 01:17:49 | Re: Change RangeVarGetRelidExtended() to take flags argument? |