From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Fix inadequate locking during get_rel_oids(). |
Date: | 2018-03-06 00:57:54 |
Message-ID: | 20180306005753.GC1878@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Mon, Mar 05, 2018 at 04:34:09PM -0800, Andres Freund wrote:
> Scratch that, we should be going down the
> /* If caller supplied OID, there's nothing we need do here. */
> if (OidIsValid(vrel->oid))
> {
> oldcontext = MemoryContextSwitchTo(vac_context);
> vacrels = lappend(vacrels, vrel);
> MemoryContextSwitchTo(oldcontext);
> }
> branch in expand_vacuum_rel() for autovacuum, so this shouldn't
> matter. Sorry for the noise
Yes, I don't see a problem. However I can understand that it is easy to
be confused on those code paths if you are not used to them and this
area has changed quite a bit the last years. Perhaps we could add an
Assert(IsAutoVacuumWorkerProcess()) to reduce the confusion?
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2018-03-06 00:58:04 | Re: [COMMITTERS] pgsql: Fix inadequate locking during get_rel_oids(). |
Previous Message | Tom Lane | 2018-03-06 00:53:23 | Re: [COMMITTERS] pgsql: Fix inadequate locking during get_rel_oids(). |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2018-03-06 00:58:04 | Re: [COMMITTERS] pgsql: Fix inadequate locking during get_rel_oids(). |
Previous Message | Tom Lane | 2018-03-06 00:57:44 | Re: Change RangeVarGetRelidExtended() to take flags argument? |