| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, TipTop Labs <office(at)tiptop-labs(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14999: pg_rewind corrupts control file global/pg_control |
| Date: | 2018-03-05 09:01:11 |
| Message-ID: | 20180305090111.GI2266@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Mon, Mar 05, 2018 at 05:47:06PM +0900, Masahiko Sawada wrote:
> Since files other than relation files such as vm, fsm, WAL are
> categorize as FILE_ACTION_COPY_CONFIG, I think the name would cause
> misreading. For example, we can use FILE_ACTION_COPY_DATA and
> FILE_ACTION_COPY_OTHER?
I am not stopped on a given name.
> As you mentioned before, with this patch we end up ignoring file-open
> error of database files other than relation files. I guess it's a bit
> risky. We can enter them to COPY_DATA but I'd defer it to committer.
COPY_DATA is aimed at being used on files which can be parsed by
blocks. You cannot do that with VMs and FSMs. Now you are true that we
could complain for non-configuration files which need to be
fully-copied, still Postgres issues a fsync on all the files of the data
folder when beginning recovery, so you would bump on problems anyway
after restarting the rewound instance.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Clough | 2018-03-05 11:34:47 | RE: BUG #15067: Documentation or behaviour bug with autovacuum thresholds? |
| Previous Message | Masahiko Sawada | 2018-03-05 08:47:06 | Re: BUG #14999: pg_rewind corrupts control file global/pg_control |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2018-03-05 09:04:02 | Re: ON CONFLICT DO UPDATE for partitioned tables |
| Previous Message | Jeevan Chalke | 2018-03-05 08:56:41 | Re: [HACKERS] Partition-wise aggregation/grouping |