| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Incorrect use of "an" and "a" in code comments and docs |
| Date: | 2018-03-05 05:42:14 |
| Message-ID: | 20180305054214.GC2266@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 05, 2018 at 01:58:54PM +0900, Michael Paquier wrote:
> While looking at something else, I have one one occurence of $subject.
> Looking more deeply at the code I have found 10 more of them, like:
> - sinval is a signal invalidation, so it seems to me that "a" is
> correct, not "an".
> - I bumped into "an" being used instead of "and" in the GIN code.
> - config/c-library.m4 also includes one. If that code is from somewhere
> else, fixing this typo would not be appropriate perhaps?
>
> Attached is a proposal of patch to fix all those things.
And of course I forgot to attach the actual patch. (Thanks Thomas for
telling me off-list).
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pg-code-pronouns.patch | text/x-diff | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Abhijit Menon-Sen | 2018-03-05 05:51:18 | Re: Incorrect use of "an" and "a" in code comments and docs |
| Previous Message | Ashutosh Bapat | 2018-03-05 05:30:33 | Re: [HACKERS] PoC: full merge join on comparison clause |