| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Banck <michael(dot)banck(at)credativ(dot)de> |
| Subject: | Re: Online enabling of checksums |
| Date: | 2018-03-02 14:17:36 |
| Message-ID: | 20180302141736.n53swzhjxhkhaljm@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Magnus Hagander wrote:
> On Wed, Feb 28, 2018 at 10:07 PM, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com
> > I'd argue this is merely a mistake in the --help text. Firstly,
> > relfilenodes are OIDs too, so I don't think "-o" is incorrect. Secondly,
> > the SGML docs actually say:
> Yeah, that one is my fault. It used to say oid all over but I noticed and
> fixed it. Except I clearly missed the --help.
Obviously option names are completely arbitrary -- you could say
"-P relfilenode" and it'd still be 'correct', since it works as
documented. But we try to make these options mnemotechnic when we can,
and I don't see any relation between "-o" and "relfilenode", so I
suggest picking some other letter. There's a whole alphabet out there.
Either "-r" or "-f" works better for me than "-o".
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2018-03-02 14:22:33 | Re: Online enabling of checksums |
| Previous Message | Alvaro Herrera | 2018-03-02 14:13:51 | Re: perltidy version |