| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Aditya Nugraha <vortexilation(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, pgsql-general(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Error when compiling postgresql 9.6.7 with Visual Studio 15.5.6 |
| Date: | 2018-02-20 01:37:32 |
| Message-ID: | 20180220013732.GE26999@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
On Mon, Feb 19, 2018 at 04:17:18PM -0500, Tom Lane wrote:
> Well, as far as I'm concerned the patch that was proposed there is
> far too fragile to be acceptable. We need to find out what the
> Microsoft-approved way of getting the information is. Assuming that
> we know the contents of non-exported data structures is surely not
> what they have in mind, and it would undoubtedly break in the next VS
> update.
Definitely agreed. The locale-related code is *the* pain point when it
comes to MSVC things. And each time we add support for a new version of
MSVC there is always something different happening and breaking. There
has never been any discussion around ResolveLocaleName() though. A
downside is that this would increase the minimal version support bar on
Windows. Still that would be worth a serious look.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dylan Luong | 2018-02-20 05:25:25 | Performance issues during backup |
| Previous Message | David Wheeler | 2018-02-19 22:08:23 | Re: Deadlock with 2 processes waiting on transactionids and locking unrelated tables |