Re: proposal: alternative psql commands quit and exit

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Daniel Verite <daniel(at)manitou-mail(dot)org>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Everaldo Canuto <everaldo(dot)canuto(at)gmail(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net>, Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: alternative psql commands quit and exit
Date: 2018-02-12 06:28:53
Message-ID: 20180212062853.GA6385@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 2, 2018 at 12:39:28AM -0500, Bruce Momjian wrote:
> I just thought of an inconsistency. First, we now consistently exit with
> 'exit', 'quit', and '\q' if used in an empty psql query buffer. Also, we now
> hint when 'exit' and 'quit' are used in non-empty query buffers:
>
> test=> SELECT
> test-> exit
> --> Use \q to quit.
>
> We obviously don't need to hint for '\q' since it works in this context.
>
> Where it is odd is that we hint for 'exit' and 'quit' in places that
> '\q' doesn't work, but we don't hint for '\q' in the same contexts.
> Here is the hint for 'exit' and 'quit':
>
> test=> SELECT '
> test'> exit
> --> Use control-D to quit.
>
> but we don't hint for '\q':
>
> test=> SELECT '
> test'> \q
> --> test'>
>
> Should we give the same "Use control-D to quit." hint here for '\q'?
> I think it is logical that we should.

I have applied the attached patch giving a ^D/^C hint where \q is
ignored, and add C comment documenting why exit/quit is not documented.

I consider this issue closed, or quited, or exited. :-)

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

Attachment Content-Type Size
exit.diff text/x-diff 2.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2018-02-12 06:46:31 [WiP] GiST intrapage indexing
Previous Message Thomas Munro 2018-02-12 06:06:08 Re: A space-efficient, user-friendly way to store categorical data