Re: proposal: alternative psql commands quit and exit

On Thu, Feb 1, 2018 at 12:01:37PM +0100, Daniel Verite wrote:
> Bruce Momjian wrote:
>
> > One open issue is the existing help display is inaccurate on Windows:
> >
> > Use \\? for help or press control-C to clear the input buffer.
>
> ! #ifndef WIN32
> ! puts(_("Use control-D to quit."));
> ! #else
> ! puts(_("Use control-C to quit."));
> ! #endif
>
> But Control-C exiting on Windows is a bug, isn't it?
> Shouldn't we try to fix it to behave like in Unix
> rather than documenting it?

Uh, don't Windows users expect Control-C to exit? In some ways Unix
folks might think that too. I don't know if we should change it, but
that is beyond the scope of this patch.

> Also, the fact that Control-D can quit in the middle of a
> multiline query without any confirmation is a usability problem, because
> you can always fat-finger a Ctrl+key. By comparison, bash doesn't
> accept it and emits the same error as if a script was improperly
> terminated. Example:
>
> $ cat '
> > [Hit Ctrl+D here] bash: unexpected EOF while looking for matching `''
> bash: syntax error: unexpected end of file
> $

Again, beyond the scope of this patch.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +