| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Exclude unlogged tables from base backups |
| Date: | 2018-01-29 12:54:48 |
| Message-ID: | 20180129125448.GA19316@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 29, 2018 at 07:28:22PM +0900, Masahiko Sawada wrote:
> Thank you for updating the patch! The patch looks good to me. But I
> have a question; can we exclude temp tables as well? The pg_basebackup
> includes even temp tables. But I don't think that it's necessary for
> backups.
They are not needed in base backups. Note that RemovePgTempFiles() does
not remove temporary relfilenodes after a crash per the comments on its
top. I have not looked at the patch in details, but if you finish by
not including those files in what's proposed there is much refactoring
possible.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ildar Musin | 2018-01-29 12:55:05 | Re: General purpose hashing func in pgbench |
| Previous Message | Arthur Zakirov | 2018-01-29 12:47:41 | Re: A Generic Question about Generic type subscripting |