| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Christophe Courtois <christophe(dot)courtois(at)dalibo(dot)com> |
| Cc: | pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: pg_hba_file_rules: "scram-sha256" instead of "scram-sha-256" |
| Date: | 2018-01-26 23:44:28 |
| Message-ID: | 20180126234428.GA1039@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Jan 26, 2018 at 05:22:59PM +0100, Christophe Courtois wrote:
> But it appears as "scram-sha256" (only one hyphen) in pg_hba_file_rules.
> This is a bit confusing.
Thanks for the report. That's a bug.. Likely from some incorrect
rebase during the feature review.
> "scram-sha256" appears in commit c727f120 in src/backend/libpq/hba.c,
> while defining the array UserAuthName.
>
> Is it just a remnant of previous versions of the patch or is there a
> reason?
Attached is a patch for that. At the same time I have noticed that
protocol.sgml is using the same name, so I would suggest to fix that at
the same time. That introduces a small user-visible change when using
pg_hba_file_rules still that should be backpatched.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| scram-hba-fix.patch | text/x-diff | 741 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-01-26 23:45:18 | Re: BUG #14932: SELECT DISTINCT val FROM table gets stuck in an infinite loop |
| Previous Message | Tom Lane | 2018-01-26 23:22:26 | Re: BUG #14932: SELECT DISTINCT val FROM table gets stuck in an infinite loop |