| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Mark Dilger <hornschnorter(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Boolean partitions syntax |
| Date: | 2018-01-26 16:07:25 |
| Message-ID: | 20180126160725.GG2416@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert,
* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> On Thu, Jan 25, 2018 at 8:44 PM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> > Attached updated patch.
>
> I wonder if this patch is just parser bloat without any real benefit.
> It can't be very common to want to partition on a Boolean column, and
> if you do, all this patch does is let you drop the quotes. That's not
> really a big deal, is it?
I've already had two people mention that it'd be neat to have PG support
it, so I don't believe it'd go unused. As for if we should force people
to use quotes, my vote would be no because we don't require that for
other usage of true/false in the parser and I don't see any reason why
this should be different.
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ildar Musin | 2018-01-26 16:07:28 | Re: [HACKERS] Custom compression methods |
| Previous Message | Robert Haas | 2018-01-26 15:56:49 | Re: Documentation of pgcrypto AES key sizes |