Re: Unimpressed with pg_attribute_always_inline

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Unimpressed with pg_attribute_always_inline
Date: 2018-01-09 01:30:10
Message-ID: 20180109013010.4e3htwvs3aza2ehw@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2018-01-08 20:20:09 -0500, Tom Lane wrote:
> No, you have it right. I checked locally and confirmed Andres' assertion
> that by default, gcc (my version anyway) is not persuaded to inline
> ExecHashJoinImpl simply by "inline", but "always_inline" persuades it.
> Maybe at some level higher than -O2, or with some other weird flag,
> it would do what we want; but we probably don't want to mess with global
> compiler flags for this.

There's -finline-limit=n, but as you say, I don't think we want to mess
with this.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-01-09 01:58:29 Re: PATCH: Configurable file mode mask
Previous Message Alvaro Herrera 2018-01-09 01:29:52 Re: proposal: alternative psql commands quit and exit