Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Implement channel binding tls-server-end-point for SCRAM
Date: 2018-01-08 13:14:11
Message-ID: 20180108131411.GA76418@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Jan 06, 2018 at 09:10:51AM +0900, Michael Paquier wrote:
> On Sat, Jan 6, 2018 at 2:56 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Good idea as a whole, but I don't think this is the right approach. As
> we include $(bindir) in PATH when running the prove command, why not
> getting the include path from "pg_config --includedir"?

So, I have been looking at that, and I propose the following
counter-patch which implements this idea by adding a new routine as
TestLib::config_check which is able to check within pg_config.h if a
given regexp matches or not for the installation on which TAP tests are
being run. I have tested with Postgres compiled with both OpenSSL 1.0.1
and 1.0.2, in which case the connection test respectively fails and
passes, causing the test to be correctly handled. This is based on
Peter's patch upthread.
--
Michael

Attachment Content-Type Size
fix_ssl_tests_scram_v2.patch text/plain 2.5 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2018-01-08 15:44:11 Re: pgsql: Implement channel binding tls-server-end-point for SCRAM
Previous Message Tom Lane 2018-01-08 02:22:25 Re: pgsql: Improve error handling in RemovePgTempFiles().

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-01-08 13:18:32 Re: [HACKERS] Timeline ID in backup_label file
Previous Message Thomas Munro 2018-01-08 11:41:36 Re: Condition variable live lock