| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: pg_upgrade: simplify code layout in a few places |
| Date: | 2018-01-06 00:00:21 |
| Message-ID: | 20180106000021.upzfsedvor4uriqp@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2018-01-05 18:57:55 -0500, Bruce Momjian wrote:
> On Fri, Jan 5, 2018 at 03:51:15PM -0800, Andres Freund wrote:
> > On 2018-01-05 14:20:59 -0500, Robert Haas wrote:
> > > On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > > > pg_upgrade: simplify code layout in a few places
> > > >
> > > > Backpatch-through: 9.4 (9.3 didn't need improving)
> > >
> > > Hmm. We don't normally do things like this, because it breaks translatability.
> >
> > Also, leaving translatability aside, why was *any* of this backpatched?
> > Unless there's very good maintainability reasons we normally don't
> > backpatch minor refactorings?
>
> Tom has preferred that I backpatch all safe patches so we keep that code
> consistent so we can backpatch other things more easily.
I've a hard time believing this. Tom?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-01-06 00:10:51 | Re: pgsql: Implement channel binding tls-server-end-point for SCRAM |
| Previous Message | Bruce Momjian | 2018-01-05 23:57:55 | Re: pgsql: pg_upgrade: simplify code layout in a few places |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-01-06 00:10:51 | Re: pgsql: Implement channel binding tls-server-end-point for SCRAM |
| Previous Message | Bruce Momjian | 2018-01-05 23:57:55 | Re: pgsql: pg_upgrade: simplify code layout in a few places |