Re: pgsql: pg_upgrade: simplify code layout in a few places

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: pg_upgrade: simplify code layout in a few places
Date: 2018-01-05 23:51:15
Message-ID: 20180105235115.73ea64bzplxe7ebh@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2018-01-05 14:20:59 -0500, Robert Haas wrote:
> On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > pg_upgrade: simplify code layout in a few places
> >
> > Backpatch-through: 9.4 (9.3 didn't need improving)
>
> Hmm. We don't normally do things like this, because it breaks translatability.

Also, leaving translatability aside, why was *any* of this backpatched?
Unless there's very good maintainability reasons we normally don't
backpatch minor refactorings?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2018-01-05 23:57:55 Re: pgsql: pg_upgrade: simplify code layout in a few places
Previous Message Robert Haas 2018-01-05 20:22:51 pgsql: Factor error generation out of ExecPartitionCheck.

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2018-01-05 23:57:55 Re: pgsql: pg_upgrade: simplify code layout in a few places
Previous Message Alvaro Herrera 2018-01-05 22:23:08 Re: [HACKERS] Proposal: Local indexes for partitioned table