| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Enhance pg_stat_wal_receiver view to display connected host |
| Date: | 2018-01-05 12:15:36 |
| Message-ID: | 20180105121536.gdoiui7qaiprinve@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Haribabu Kommi wrote:
> And also not returning "default host" details, because for the conninfo
> without any host details, the return value must be NULL. But this change
> may break the backward compatibility of the function.
I wouldn't want to have to fight that battle.
> or
>
> write two new functions PQconnhost() and PQconnhostaddr() to return the
> connected host and hostaddr and reuse the PQport() function.
How about using an API similar to PQconninfo, where we return an array
of connection options used? Say, PQeffectiveConninfo(). This seems to
me to reduce ugliness in the API, and be more generally useful.
walrecvr could display as an array or just flatten to a string -- not
sure what's the better option there.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-01-05 12:42:20 | Re: [Patch] Make block and file size for WAL and relations defined at cluster creation |
| Previous Message | Amit Khandekar | 2018-01-05 12:12:08 | Re: [HACKERS] UPDATE of partition key |