Re: pgsql: Fix deadlock hazard in CREATE INDEX CONCURRENTLY

Tom Lane wrote:

> No, I think that's probably a bad idea, because it would mean that in
> cases where you do care about the finishing order (which is all of
> them up to now), the test output would fail to prove that you got the
> expected behavior.

Hmm .. I was thinking that we would check all the steps that are
unlocked when running a single one, so the only test that would be
affected would be deadlock-hard, which has this:

step s8a1: LOCK TABLE a1; <waiting ...>
step s8a1: <... completed>
step s7a8: <... completed>
error in steps s8a1 s7a8: ERROR: deadlock detected

TBH I'm surprised that this is never reported in the other order but
that this doesn't hold for the new test, but there you have it.

> At this point I'm on board with using an alternate expected file.
> We could revert the test back to your original version and make
> the pre-9.6 branches look the same, which would be good.

I reverted the test change, so the tests are now the same everywhere. I
hadn't touched 9.4 and 9.5 previously. The failures in 9.6-10-master
had been accumulating fast, and we didn't have a single failure in 9.4
and 9.5, so I'm hoping that this means the older branches just cannot
fail in this way. But we shall see.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services