Re: [HACKERS] Add support for tuple routing to foreign partitions

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Maksim Milyutin <milyutinma(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: [HACKERS] Add support for tuple routing to foreign partitions
Date: 2017-12-18 14:25:47
Message-ID: 20171218142547.etmgtieuhokpuuam@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

InitResultRelInfo becomes unintelligible after this patch -- it was
straightforward but adding partition_root makes things shaky. Please
add a proper comment indicating what each argument is. (I wonder why
this function needs a local variable "partition_check" -- seems
pointless).

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2017-12-18 15:07:52 Re: [HACKERS] [PATCH] Improve geometric types
Previous Message Huong Dangminh 2017-12-18 14:25:11 RE: User defined data types in Logical Replication