Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: "Wood, Dan" <hexpert(at)amazon(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, pgsql-committers(at)postgresql(dot)org, "Wong, Yi Wen" <yiwong(at)amazon(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple
Date: 2017-12-06 08:03:19
Message-ID: 20171206080319.v7of3p45yvapkgla@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2017-11-20 11:18:45 -0800, Andres Freund wrote:
> Hi,
>
> On 2017-11-13 19:03:41 -0800, Andres Freund wrote:
> > Hi,
> >
> > On 2017-11-03 07:53:30 -0700, Andres Freund wrote:
> > > Here's that patch. I've stared at this some, and Robert did too. Robert
> > > mentioned that the commit message might need some polish and I'm not
> > > 100% sure about the error message texts yet.
> > >
> > > I'm not yet convinced that the new elog in vacuumlazy can never trigger
> > > - but I also don't think we want to actually freeze the tuple in that
> > > case.
> >
> > I'm fairly sure it could be triggered, therefore I've rewritten that.
> >
> > I've played around quite some with the attached patch. So far, after
> > applying the second patch, neither VACUUM nor VACUUM FULL / CLUSTER make
> > the situation worse for already existing corruption. HOT pruning can
> > change the exact appearance of existing corruption a bit, but I don't
> > think it can make the corruption meaningfully worse. It's a bit
> > annoying and scary to add so many checks to backbranches but it kinda
> > seems required. The error message texts aren't perfect, but these are
> > "should never be hit" type elog()s so I'm not too worried about that.
> >
> >
> > Please review!
>
> Ping? Alvaro, it'd be good to get some input here.

Ping. I'm a bit surprised that a bug fixing a significant data
corruption issue has gotten no reviews at all.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Khandekar 2017-12-06 08:43:49 Re: pgsql: Support Parallel Append plan nodes.
Previous Message amul sul 2017-12-06 06:15:17 Re: pgsql: Support Parallel Append plan nodes.

Browse pgsql-hackers by date

  From Date Subject
Next Message amul sul 2017-12-06 09:01:24 Re: pgsql: Support Parallel Append plan nodes.
Previous Message David Rowley 2017-12-06 07:51:15 Re: [HACKERS] Runtime Partition Pruning