| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Errands around AllocateDir() |
| Date: | 2017-12-04 19:11:34 |
| Message-ID: | 20171204191134.2cpxmvvn7fkwaze5@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Yeah, agreed. The only thing I'm concerned about back-patching is
> the places where a wrong errno might be reported.
If we're currently reporting "could not open dir: Success" then
backpatching such a fix is definitely an improvement. OTOH if currently
we have opendir() trying to report a failure, then LWLockRelease replace
the errno because something completely unrelated also failed, having the
message report exactly the opendir() failure rather than the lwlock
failure is surely also an improvement.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-12-04 20:15:08 | Is it OK to ignore directory open failure in ResetUnloggedRelations? |
| Previous Message | Tom Lane | 2017-12-04 19:00:13 | Re: Errands around AllocateDir() |