Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there

From: Raphael Hertzog <hertzog(at)debian(dot)org>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there
Date: 2017-11-08 07:42:18
Message-ID: 20171108074218.dnsvnsye632odvpk@home.ouaza.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi Michael,

On Wed, 08 Nov 2017, Michael Paquier wrote:
> Raphaël, don't you have problems with pg_twophase as well? Wouldn't
> the new fsync call in CheckPointTwoPhase() fail equally if no 2PC
> transactions have happened in a checkpoint cycle? That would not be an
> issue with pg_commit_ts and pg_xact normally, but we are talking about
> checkpoints skipped or not depending on WAL activity, tracking which
> is more properly done in v10.

I don't know. It's quite possible, I have not used PostgreSQL 10
extensively in Kali... I rely on Kali users for this.

I just checked and the usual database initialization code does not trigger
any write to pg_twophase so if there's a new fsync() on that directory
without any prior write, it's quite possible that this could fail later
on during PostgreSQL's use.

Cheers,
--
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2017-11-08 07:53:49 Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there
Previous Message Michael Paquier 2017-11-08 01:42:09 Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there