Re: SIGSEGV in BRIN autosummarize

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: SIGSEGV in BRIN autosummarize
Date: 2017-10-18 16:54:09
Message-ID: 20171018165409.2cznyyugvqigtktt@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Justin Pryzby wrote:

> No crashes in ~28hr. It occurs to me that it's a weaker test due to not
> preserving most compilation options.

And the previous code crashes in 45 minutes? That's solid enough for
me; I'll clean up the patch and push in the next few days. I think what
you have now should be sufficient for the time being for your production
system.

> If I understand, our crash isn't explained by the avw_database test
> anyway (?)

I don't see why you would think that -- I disagree.

> Should I make clean and recompile with all non-prefix options and a minimal
> patch (avw_database==MyDatabaseId || continue) ?
>
> Or recompile with existing options but no patch to first verify crash occurs
> with locally compiled binary?

I don't think either of these actions is necessary.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-10-18 16:58:27 Re: [COMMITTERS] pgsql: Implement table partitioning.
Previous Message Justin Pryzby 2017-10-18 16:48:55 Re: SIGSEGV in BRIN autosummarize