Re: pgsql: Add pg_strnlen() a portable implementation of strlen.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add pg_strnlen() a portable implementation of strlen.
Date: 2017-10-10 22:39:51
Message-ID: 20171010223951.cn2oaijecml2s7ro@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2017-10-10 18:10:15 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Here's a fix. Not quite sure whether we really need the
> > HAVE_DECL_STRNLEN test, added it for symmetry.
>
> LGTM.

Thanks for checking.

> I think the DECL test is a good idea; the system definition
> might be a macro or otherwise weird, in which case we'd cause problems
> if we write an extern definition anyway.

I was thinking about protecting it with HAVE_STRNLEN rather than not
protecting it at all. But this works, so whatever ;)

Greetings,

Andres Freund

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-10-10 23:14:10 pgsql: Regenerate configure script.
Previous Message Andres Freund 2017-10-10 22:38:28 pgsql: Rewrite strnlen replacement implementation from 8a241792f96.