| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Add pg_strnlen() a portable implementation of strlen. |
| Date: | 2017-10-10 20:46:03 |
| Message-ID: | 20171010204603.sgcia7xtuhqvjumj@alap3.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2017-10-10 16:37:04 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > (there's definitely fixes to be made to where strnlen's replacement is
> > located, but regardless, this needs to be fixed too)
>
> Given that strnlen is standardized by POSIX, and has been for nigh a
> decade, I think it'd be all right for us to treat it as a straight
> port replacement function, a la strlcpy() for instance. That is,
> forget the pg_ prefix and just create a strnlen() function if the
> platform has not got it.
Yea, I'm ok with that. But can't do that before the configure issue on
these boxes is fixed, otherwise we'll likely get symbol conflicts...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-10-10 20:51:39 | Re: pgsql: Add pg_strnlen() a portable implementation of strlen. |
| Previous Message | Tom Lane | 2017-10-10 20:37:04 | Re: pgsql: Add pg_strnlen() a portable implementation of strlen. |