Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.
Date: 2017-09-19 16:10:12
Message-ID: 20170919161012.i3j4ugktf2xkr4kb@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2017-09-19 07:48:42 -0400, Robert Haas wrote:
> Oh, I've not seen that. Mostly, what I think we should fix is the
> fact that the libpq messages tend to report that the server crashed
> even if it was an orderly shutdown.
>
> [rhaas ~]$ psql
> psql (11devel)
> Type "help" for help.
>
> rhaas=# select 1;
> FATAL: terminating connection due to administrator command
> server closed the connection unexpectedly
> This probably means the server terminated abnormally
> before or while processing the request.
> The connection to the server was lost. Attempting reset: Failed.
>
> It's sort of funny (but also sort of sad) that we've got libpq talking
> down the server's reliability (and even in the face of evidence which
> manifestly contradicts it).

Yea, I'm not very happy with that either. I really think we should stop
emitting that if we got an actual message from the server.

Unfortunately the backends themselves also react with inaccurate error
messages to things like immediate shutdowns...

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-09-19 16:13:54 Re: pgsql: Add test for postmaster crash restarts.
Previous Message Tom Lane 2017-09-19 15:11:31 Re: Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2017-09-19 16:13:43 Re: type cache for concat functions
Previous Message Peter Geoghegan 2017-09-19 16:03:43 Re: Boom filters for hash joins (was: A design for amcheck heapam verification)