| From: | Ryan Murphy <ryanfmurphy(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info> |
| Subject: | Re: Small patch for pg_basebackup argument parsing |
| Date: | 2017-09-18 05:11:07 |
| Message-ID: | 20170918051107.1354.37488.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: not tested
I applied this patch via patch -p1. (Had an issue using git apply, but apparently that's common?)
All tests passed normally. Ran make check, make installcheck, and make installcheck-world.
Looked thru the diffs and it looks fine to me.
Changing a lot of a integer/long arguments that were being read directly via atoi / atol
to be read as strings first, to give better error handling.
This looks good to go to me. Reviewing this as "Ready for Committer".
Thanks for the patch, Pierre!
Ryan
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-09-18 05:39:32 | Re: valgrind vs. shared typmod registry |
| Previous Message | Amit Khandekar | 2017-09-18 05:05:29 | Re: Parallel Append implementation |