| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: More efficient truncation of pg_stat_activity query strings |
| Date: | 2017-09-15 20:49:10 |
| Message-ID: | 20170915204910.oxt55ayeft7nvedm@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-09-15 16:45:47 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Version correcting these is attached. Thanks!
>
> I'd vote for undoing the s/st_activity/st_activity_raw/g business.
> That may have been useful while writing the patch, to ensure you
> found all the references; but it's just creating a lot of unnecessary
> delta in the final code, with the attendant hazards for back-patches.
I was wondering about that too (see [1]). My only concern is that some
extensions out there might be accessing the string expecting it to be
properly truncated. The rename at least forces them to look for the new
name... I'm slightly in favor of keeping the rename, it doesn't seem
likely to cause a lot of backpatch pain.
Regards,
Andres Freund
[1] http://archives.postgresql.org/message-id/20170914060329.j7lt7oyyzquxiut6%40alap3.anarazel.de
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-09-15 20:56:45 | Re: pgsql: Add support for coordinating record typmods among parallel worke |
| Previous Message | Tom Lane | 2017-09-15 20:45:47 | Re: More efficient truncation of pg_stat_activity query strings |