Re: Patches that don't apply or don't compile: 2017-09-12

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: a(dot)alekseev(at)postgrespro(dot)ru
Cc: pgsql-hackers(at)postgresql(dot)org, bossartn(at)amazon(dot)com, yangjie(at)highgo(dot)com, a(dot)korotkov(at)postgrespro(dot)ru, amitdkhan(dot)pg(at)gmail(dot)com, Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp, dignoes(at)inf(dot)unibz(dot)it, daniel(at)yesql(dot)se, 9erthalion6(at)gmail(dot)com, elprans(at)gmail(dot)com, hlinnaka(at)iki(dot)fi, pgsql(at)j-davis(dot)com, Jim(dot)Nasby(at)BlueTreble(dot)com, markm(dot)rofail(at)gmail(dot)com, kleptog(at)svana(dot)org, sawada(dot)mshk(at)gmail(dot)com, pavan(dot)deolasee(at)gmail(dot)com, pavel(dot)stehule(at)gmail(dot)com, peter(dot)eisentraut(at)2ndquadrant(dot)com, petr(dot)jelinek(at)2ndquadrant(dot)com, p(dot)psql(at)pinaraf(dot)info, rafia(dot)sabih(at)enterprisedb(dot)com, simon(at)2ndquadrant(dot)com, funny(dot)falcon(at)postgrespro(dot)ru, tianzhouchen(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, tomas(dot)vondra(at)2ndquadrant(dot)com, v(dot)drobny(at)postgrespro(dot)ru, nagata(at)sraoss(dot)co(dot)jp
Subject: Re: Patches that don't apply or don't compile: 2017-09-12
Date: 2017-09-13 02:03:32
Message-ID: 20170913.110332.76800659.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello, aside from the discussion on the policy of usage of
automation CI, it seems having trouble applying patches.

https://travis-ci.org/postgresql-cfbot/postgresql/builds/274777750
>1363 heapam.c:2502:18: error: ‘HEAP_INSERT_SKIP_WAL’ undeclared (first use in this function)
>1364 if (!(options & HEAP_INSERT_SKIP_WAL) && RelationNeedsWAL(relation))

These lines shows that the patch is applied halfway.

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-09-13 02:04:05 Re: generated columns
Previous Message Tsunakawa, Takayuki 2017-09-13 01:41:12 Re: Supporting huge pages on Windows