| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Simone Gotti <simone(dot)gotti(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix drop replication slot blocking instead of returning error |
| Date: | 2017-08-30 13:33:13 |
| Message-ID: | 20170830133313.ozsj3zsmsxinqgfx@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Craig Ringer wrote:
> > FWIW, I also don't think it's ok to just change the behaviour
> > unconditionally and without a replacement for existing behaviour.
>
> Seems like it just needs a new argument nowait DEFAULT false
I added a WAIT flag to DROP_REPLICATION_SLOT, preliminary patch
attached. Running tests now.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-a-WAIT-option-to-DROP_REPLICATION_COMMAND.patch | text/plain | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-08-30 13:39:13 | Re: Parallel worker error |
| Previous Message | Tom Lane | 2017-08-30 13:24:28 | Re: LWLock optimization for multicore Power machines |