| From: | Ryan Murphy <ryanfmurphy(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: assorted code cleanup |
| Date: | 2017-08-29 07:32:46 |
| Message-ID: | 20170829073246.23546.85121.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
I've reviewed the code changes, and it's pretty clear to me that they clean things up a bit while not changing any behavior. They simplify things in a way that make the code more comprehensible. I've run all the tests and they behave the same way as they did before the patch. I also trying manually playing around the the function in question, `metaphone`, and it seems to behave the same as before.
I think it's ready to commit!
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-08-29 07:37:01 | Re: [BUGS] [postgresql 10 beta3] unrecognized node type: 90 |
| Previous Message | amul sul | 2017-08-29 07:32:03 | Re: Hash Functions |