Re: Replication to Postgres 10 on Windows is broken

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Noah Misch <noah(at)leadboat(dot)com>, "Augustine, Jobin" <jobin(dot)augustine(at)openscg(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Replication to Postgres 10 on Windows is broken
Date: 2017-08-06 21:55:21
Message-ID: 20170806215521.d6fq4esvx7s5ejka@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2017-08-06 13:07:42 -0700, Andres Freund wrote:
> Is anybody working on a patch like this? I can try writing one blindly,
> if somebody else tests it. But if somebody natively on windows is
> working on it, that's going to be more efficient. It'd be nice to have
> something merged by wrap tomorrow...

Here's a prototype patch implementing what Tom outlined. I've compiled
it with mingw under linux, but haven't run it. Could some windows
capable person take this for a spin?

Unfortunately we can't just push this to the BF and see what it says -
our tests don't catch this one... And there's not that much time before
the wrap.

Anybody have an opinion about adding ifs for WL_SOCKET_CONNECTED to
!win32 implementations rather than redefining it to WL_SOCKET_WRITEABLE?

- Andres

Attachment Content-Type Size
connected.diff text/x-diff 6.3 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2017-08-06 22:04:49 Re: Replication to Postgres 10 on Windows is broken
Previous Message Peter Geoghegan 2017-08-06 21:17:41 Re: Crash report for some ICU-52 (debian8) COLLATE and work_mem values

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-08-06 22:04:49 Re: Replication to Postgres 10 on Windows is broken
Previous Message Andres Freund 2017-08-06 21:37:31 Re: snapbuild woes