From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Why does logical replication launcher exit with exit code 1? |
Date: | 2017-08-02 20:57:57 |
Message-ID: | 20170802205757.kxv7542pmopupvdm@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2017-08-02 16:52:01 -0400, Robert Haas wrote:
> On Wed, Aug 2, 2017 at 4:38 PM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> > Maybe it doesn't need to be logged at all (other than perhaps as DEBUG)?
> > A few months ago, people were complaining about too many messages about
> > background workers starting. Now we are having complaints about
> > messages about background workers stopping.
>
> I actually don't think it's that unreasonable to get notified when
> system-wide processes like the autovacuum launcher or the logical
> replication launcher start or stop. That's stuff somebody might want
> to know. It's not going to generate a lot of log volume, and it might
> be useful, so why suppress it?
>
> Where things get ugly is if you start to get a high rate of messages -
> e.g. from starting and stopping parallel query workers or other kinds
> of things where you might have workers starting and stopping very
> frequently. But surely this isn't an example of that.
I generally agree. But in the shutdown case it's just useless and
confusing - the launcher is stopping because the entire server is being
stopped, and that's very much not clear from the message.
- Andres
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-08-02 21:09:10 | Re: Why does logical replication launcher exit with exit code 1? |
Previous Message | Robert Haas | 2017-08-02 20:52:01 | Re: Why does logical replication launcher exit with exit code 1? |