| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: More race conditions in logical replication |
| Date: | 2017-07-24 23:33:08 |
| Message-ID: | 20170724233308.rfzygeusgolvjtwd@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> I'm back at looking into this again, after a rather exhausting week. I
> think I have a better grasp of what is going on in this code now,
Here's an updated patch, which I intend to push tomorrow.
> and it
> appears to me that we should change the locking so that active_pid is
> protected by ReplicationSlotControlLock instead of the slot's spinlock;
> but I haven't analyzed the idea fully yet and I don't have the patch
> done yet either.
This doesn't seem to be a good idea actually.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Wait-for-slot-to-become-free-in-when-dropping-it.patch | text/plain | 12.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2017-07-25 00:19:24 | Re: BUG #14759: insert into foreign data partitions fail |
| Previous Message | Tom Lane | 2017-07-24 22:55:45 | Re: VACUUM and ANALYZE disagreeing on what reltuples means |