Re: Patch: Add --no-comments to skip COMMENTs with pg_dump

From: Fabrízio Mello <fabriziomello(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Robins Tharakan <tharakan(at)gmail(dot)com>
Subject: Re: Patch: Add --no-comments to skip COMMENTs with pg_dump
Date: 2017-07-17 22:31:35
Message-ID: 20170717223135.1507.83493.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, passed
Spec compliant: not tested
Documentation: tested, passed

It's a very simple change and I have not to complain about source and documentation changes.

But I wonder the lack of tap tests of this new pg_dump behavior. Shouldn't we add tap tests?

The new status of this patch is: Waiting on Author

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2017-07-17 22:39:44 Re: Something for the TODO list: deprecating abstime and friends
Previous Message Tom Lane 2017-07-17 22:12:07 Re: Something for the TODO list: deprecating abstime and friends