Re: BUG #14738: ALTER SERVER for foregin servers not working

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp, fcs1(at)poczta(dot)onet(dot)pl, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #14738: ALTER SERVER for foregin servers not working
Date: 2017-07-13 04:42:49
Message-ID: 20170713.134249.97825982.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

At Tue, 11 Jul 2017 15:39:14 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in <6234(dot)1499801954(at)sss(dot)pgh(dot)pa(dot)us>
> Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> writes:
> > Horiguchi-san,
> > On 2017/07/11 10:28, Kyotaro HORIGUCHI wrote:
> >> I faintly recall such discussion was held aroud that time and
> >> maybe we concluded that we don't do that but I haven't find such
> >> a thread in pgsql-hackers..
>
> > I mentioned it in my reply. Here again:
> > https://www.postgresql.org/message-id/20160405.184408.166437663.horiguchi.kyotaro%40lab.ntt.co.jp
>
> The followup discussion noted that that approach was no good because it
> would only close connections in the same session that had done the ALTER
> SERVER. I think the basic idea of marking postgres_fdw connections as
> needing to be remade when next possible is OK, but we have to drive it
> off catcache invalidation events, the same as we did in c52d37c8b. An
> advantage of that way is we don't need any new hooks in the core code.
>
> Kyotaro-san, are you planning to update your old patch?

I'm pleased to do that. I will reconsider the way shown in a mail
in the thread soon.

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message jothiprasath216 2017-07-13 04:58:02 Re: BUG #14736: Crash on postgresql server by autovacuum worker process
Previous Message Kyotaro HORIGUCHI 2017-07-13 04:19:23 Re: PostgreSQL hot standby Hangs due to AccessExclusiveLock on pg_attribute or pg_type tables

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-07-13 05:13:04 Re: pg_stop_backup(wait_for_archive := true) on standby server
Previous Message Kyotaro HORIGUCHI 2017-07-13 04:20:47 Re: Typo in backend/storage/ipc/standby.c