Re: Fix a typo in snapmgr.c

From: Andres Freund <andres(at)anarazel(dot)de>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix a typo in snapmgr.c
Date: 2017-06-23 07:21:16
Message-ID: 20170623072116.imliastnpc6uhr37@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017-06-07 10:17:31 -0700, Andres Freund wrote:
> On 2017-05-08 09:12:13 -0400, Tom Lane wrote:
> > Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > > So rearranged code a little to keep it lean.
> >
> > Didn't you break it with that? As it now stands, the memcpy will
> > copy the nonzero value.
>
> I've not seen a fix and/or alleviating comment about this so far. Did I
> miss something?

Simon, FWIW, I plan to either revert or fix this up soon-ish. Unless
you're going to actually respond on this thread?

- Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-06-23 07:23:28 Re: Fix a typo in snapmgr.c
Previous Message Simon Riggs 2017-06-23 07:18:41 Re: Small bug in replication lag tracking