Re: pgsql: Assert that we don't invent relfilenodes or type OIDs in binary

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Assert that we don't invent relfilenodes or type OIDs in binary
Date: 2017-06-13 17:45:12
Message-ID: 20170613174512.GL13873@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Jun 13, 2017 at 01:39:34PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Uh, is there a reason this is only an Assert(), meaning it only checks
> > in assert builds. pg_upgrade already has a lot of checks and they are
> > all fatal.
>
> Yeah, I didn't think it was worth adding overhead to production builds
> for it.

Uh, you realize there are already many pg_upgrade sanity checks in the
backend that are not asserts, right?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-06-13 18:47:03 pgsql: psql: Use more consistent capitalization of some output headings
Previous Message Tom Lane 2017-06-13 17:39:34 Re: pgsql: Assert that we don't invent relfilenodes or type OIDs in binary